Skip to content

Issue 26349 force flag docs#26427

Merged
openshift-merge-bot[bot] merged 1 commit into
podman-container-tools:mainfrom
b3n4kh:issue-26349-force-flag-docs
Jun 17, 2025
Merged

Issue 26349 force flag docs#26427
openshift-merge-bot[bot] merged 1 commit into
podman-container-tools:mainfrom
b3n4kh:issue-26349-force-flag-docs

Conversation

@b3n4kh

@b3n4kh b3n4kh commented Jun 14, 2025 •
edited by baude
Loading

Copy link
Copy Markdown
Contributor

Fixes: #26349

Does this PR introduce a user-facing change?

Update man pages to include examples for the `--force` flag in various pages.

mheon
mheon reviewed Jun 14, 2025
View reviewed changes
Comment thread docs/source/markdown/podman-unmount.1.md.in Outdated
@mheon

mheon commented Jun 14, 2025

Copy link
Copy Markdown
Contributor

One typo, otherwise LGTM

@packit-as-a-service

packit-as-a-service Bot commented Jun 14, 2025

Copy link
Copy Markdown

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

2 similar comments
@packit-as-a-service

packit-as-a-service Bot commented Jun 14, 2025

Copy link
Copy Markdown

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@packit-as-a-service

packit-as-a-service Bot commented Jun 14, 2025

Copy link
Copy Markdown

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

Honny1
Honny1 approved these changes Jun 16, 2025
View reviewed changes

@Honny1 Honny1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@b3n4kh You will need to sign git commit -s all of your commits for our CI to pass the PR.

@b3n4kh
add more exmples applying current style for each page
6b99644 
Signed-off-by: Benjamin Akhras <b@akhras.at>
@b3n4kh b3n4kh force-pushed the issue-26349-force-flag-docs branch from b4a22b6 to 6b99644 Compare June 16, 2025 17:53
@b3n4kh

b3n4kh commented Jun 16, 2025

Copy link
Copy Markdown
Contributor Author

Thanks, LGTM.

@b3n4kh You will need to sign git commit -s all of your commits for our CI to pass the PR.

squashed the commits, preserving Signed-off line hope this is fine

@baude

baude commented Jun 16, 2025

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2025
Honny1
Honny1 approved these changes Jun 17, 2025
View reviewed changes

@Honny1 Honny1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Luap99
Luap99 approved these changes Jun 17, 2025
View reviewed changes

@Luap99 Luap99 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: b3n4kh, Honny1, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2025
@openshift-merge-bot openshift-merge-bot Bot merged commit 474740f into podman-container-tools:main Jun 17, 2025
35 of 36 checks passed
@yashuatla yashuatla mentioned this pull request Jun 25, 2025
Open
@stale-locking-app stale-locking-app Bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 16, 2025
@stale-locking-app stale-locking-app Bot locked as resolved and limited conversation to collaborators Sep 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mheon mheon mheon left review comments
@Honny1 Honny1 Honny1 approved these changes
@Luap99 Luap99 Luap99 approved these changes

Assignees

@baude baude

@Luap99 Luap99

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Manpages: Missing examples for --force flag

5 participants

@b3n4kh @mheon @baude @Honny1 @Luap99